fix(sheet): fix toolbar not showing contents in ios for ionic theme #30496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BenOsodrac
approved these changes
Jun 18, 2025
BenOsodrac
approved these changes
Jun 18, 2025
| const header = page.locator('.modal-sheet ion-header'); | ||
|
|
||
| await dragElementBy(header, page, 0, 125); | ||
| await dragElementBy(header, page, 0, 110); |
Contributor
Author
There was a problem hiding this comment.
Change required due to errors when updating the snapshots.
Error: The element is being dragged past the bottom of the viewport. Update the dragByY value to prevent going out of bounds. A recommended value is 110.5.
ShaneK
approved these changes
Jun 18, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
This looks fine to me. I'm not super happy with using z-indexes to fix this issue, but it's probably caused by other z-indexes at this point. This sort of z-index hell happens with manual manipulation like this 🫠
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
The
ion-toolbarcontents inside thesheetwere not being displayed correctly iniOS.What is the new behavior?
This PR add
z-indexvalues of theion-toolbar'scontentandbackgroundcontainers to fix the issue.Does this introduce a breaking change?
Other information
Before:
After:
